Fix disk space popup in admin users table#5879
Open
LianaHarris360 wants to merge 1 commit intolearningequality:unstablefrom
Open
Fix disk space popup in admin users table#5879LianaHarris360 wants to merge 1 commit intolearningequality:unstablefrom
LianaHarris360 wants to merge 1 commit intolearningequality:unstablefrom
Conversation
… problems in the popup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated the
UserStorageunit selector popup, removingDropdownWrapperinside the user table storage popover, while preserving the vertical dropdown positioning withmenu-props="{ offsetY: true }"Manual verification:
Before:
diskSpacePopupBefore.mov
After:
diskSpacePopupAfter.mov
References
Fixes #5706
Reviewer guidance
Test the disk space editor in both places where
UserStorageis used:The main area to check is dropdown rendering inside the table popover, since that was the broken layout.
AI usage
I used Codex to evaluate the dropdown behavior, reviewed the suggested approach, removed unnecessary shared-component changes, and manually verified the UI behavior.